On 13/11/2025 10:39, Boris Brezillon wrote: > Groups are only moved out of the runnable lists when > panthor_group_stop() is called or when they run out of jobs. > What should not happen though is having one group added to one of > the runnable list after reset.in_progress has been set to true, but > that's not something we can easily check, so let's just drop the > WARN_ON() in panthor_sched_pre_reset(). > > v2: > - Adjust explanation in commit message > > Reviewed-by: Liviu Dudau <[email protected]> > Signed-off-by: Boris Brezillon <[email protected]>
Ah, so if I wasn't so far behind on my emails I'd have spotted this updated version! ;) That commit message looks fine. Reviewed-by: Steven Price <[email protected]> > --- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c > b/drivers/gpu/drm/panthor/panthor_sched.c > index e74ca071159d..d121b794bd79 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -2836,8 +2836,6 @@ void panthor_sched_pre_reset(struct panthor_device > *ptdev) > * new jobs while we're resetting. > */ > for (i = 0; i < ARRAY_SIZE(sched->groups.runnable); i++) { > - /* All groups should be in the idle lists. */ > - drm_WARN_ON(&ptdev->base, > !list_empty(&sched->groups.runnable[i])); > list_for_each_entry_safe(group, group_tmp, > &sched->groups.runnable[i], run_node) > panthor_group_stop(group); > }
