> > On 14 Nov 2025, at 12.10, Dmitry Baryshkov > <[email protected]> wrote: > > On Tue, Oct 28, 2025 at 07:02:28PM +0200, Dmitry Baryshkov wrote: >>> On Tue, Oct 28, 2025 at 08:36:35PM +0800, Teguh Sobirin wrote: >>> Move the loop over phys_encs outside the >>> hw_mdptop->ops.setup_vsync_source block. >>> This way, vsync_sel() is called for each interface. >>> >>> This change ensures TE vsync selection works >>> even if setup_vsync_source is not implemented. >> >> Please see Documentation/processs/submitting-patches.rst. Don't describe >> the change and pleasw wrap the commit message on 72-75 chars boundary. >> >> I can suggest something like this: >> >> Since DPU 5.x the vsync source TE setup is split between MDP TOP and >> INTF blocks. Currently all code to setup vsync_source is only exectued >> if MDP TOP implements the setup_vsync_source() callback. However on >> DPU >= 8.x this callback is not implemented, making DPU driver skip all >> vsync setup. Move the INTF part out of this condition, letting DPU >> driver to setup TE vsync selection on all new DPU devices. >> >> The patch itself looks good to me. > > > Teguh, any updates on the patch? > > -- > With best wishes > Dmitry
I will send a new one with corrected commit message Regards, Teguh.
