On 11/14/25 19:33, David Hildenbrand (Red Hat) wrote: > On 14.11.25 02:22, Balbir Singh wrote: >> ret of type vm_fault_t is reused to capture the return value of >> nouveau_dmem_copy_folio(), which returns an int. Use a new variable >> err to fix the issue. The issue is not new, prior to this the function >> called was called nouveau_dmem_copy_one() and ret was used to capture >> it's value. >> >> The bug does not cause a real issue at runtime, the value is used >> as a boolean to check if nouveau_dmem_copy_folio() succeeded or failed. >> The different types should not impact the execution of the code at >> runtime. >> > > Also, as commented previously, the prefix in the subject does not match > existing norms. Take a look at > > git log --oneline drivers/gpu/drm/nouveau/nouveau_dmem.c > > and note how it's commonly something along the lines of "drm/nouveau" or > better "drm/nouveau/dmem". > > The only patch that uses "gpu/drm/nouveau" is from you recently. In fact, > there is no other patch in the codebase that uses that prefix. >
I'll fix the subject prefix Thanks for the review, Balbir
