Hi Dmitry,
> -----Original Message-----
> From: Dmitry Osipenko <[email protected]>
> Sent: Wednesday, November 12, 2025 3:07 AM
> To: Kim, Dongwon <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH v6 2/3] drm/virtio: Add support for saving and restoring
> virtio_gpu_objects
>
> On 11/12/25 14:03, Dmitry Osipenko wrote:
> > On 10/27/25 23:53, [email protected] wrote:
> >> + /* store the dmabuf imported object with its params to
> >> + * the restore list
> >> + */
> >> + memcpy(&bo->params, ¶ms, sizeof(params));
> >
> > Nit: using memcpy is unnecessary for structs, "bo->params = params"
> > would look cleaner
Yeah, you are right. I will update it.
>
> Won't hurt to add helper for adding obj to a restore list since same code
> repeats two times.
>
> virtio_gpu_add_object_to_restore_list(struct virtio_gpu_device *vgdev,
> struct virtio_gpu_object *bo) {
> ...
> }
Ok, I will.
>
> --
> Best regards,
> Dmitry
