On Thu, 13 Nov 2025, Bjorn Helgaas wrote: > On Tue, Oct 28, 2025 at 07:35:44PM +0200, Ilpo Järvinen wrote: > > pci_rebar_set_size() adjusts BAR size for both normal and IOV BARs. The > > struct pci_srvio keeps a cached copy of BAR size in unit of > > resource_size_t in ->barsz[] ... > > Nit: s/pci_srvio/pci/sriov/ (fixed locally, FYI in case you post a v2)
I just posted v2 without seeing this first. :-( I seem to never learn to type those letters in the correct order, I don't know why I always keep typing them wrong. > I'm not sure what "unit of resource_size_t" adds here, maybe could be > removed to just say this? > > struct pci_srvio keeps a cached copy of BAR size in ->barsz[] ... Seems okay with me. I just had it there to differentiate from "BAR size" which happens to often be the format directly compatible with field in the capability. -- i.
