On 11/13/25 20:09, David Hildenbrand (Red Hat) wrote: > On 13.11.25 06:13, Balbir Singh wrote: >> ret of type vm_fault_t is reused to capture the return value of >> nouveau_dmem_copy_folio(), which returns an int. Use a new copy_ret >> to fix the issue. The issue is not new, prior to this the function >> called was called nouveau_dmem_copy_one() and ret was used to capture >> it's value. >> >> Reported-by: kernel test robot <[email protected]> >> Closes: >> https://lore.kernel.org/oe-kbuild-all/[email protected]/ > > It's a sparse warning, is there any runtime effect? >
No impact really, it's just a sparse warning >> >> Cc: Andrew Morton <[email protected]> >> Cc: David Hildenbrand <[email protected]> >> Cc: Zi Yan <[email protected]> >> Cc: Joshua Hahn <[email protected]> >> Cc: Rakie Kim <[email protected]> >> Cc: Byungchul Park <[email protected]> >> Cc: Gregory Price <[email protected]> >> Cc: Ying Huang <[email protected]> >> Cc: Alistair Popple <[email protected]> >> Cc: Oscar Salvador <[email protected]> >> Cc: Lorenzo Stoakes <[email protected]> >> Cc: Baolin Wang <[email protected]> >> Cc: "Liam R. Howlett" <[email protected]> >> Cc: Nico Pache <[email protected]> >> Cc: Ryan Roberts <[email protected]> >> Cc: Dev Jain <[email protected]> >> Cc: Barry Song <[email protected]> >> Cc: Lyude Paul <[email protected]> >> Cc: Danilo Krummrich <[email protected]> >> Cc: David Airlie <[email protected]> >> Cc: Simona Vetter <[email protected]> >> Cc: Ralph Campbell <[email protected]> >> Cc: Mika Penttilä <[email protected]> >> Cc: Matthew Brost <[email protected]> >> Cc: Francois Dugast <[email protected]> >> > > Fixes: ? Or is does this just fix a sparse warning and nothing "real" we > could run into and cause problems? > > There is no "real" impact, it's a warning about the type mismatch. The return value is checked as a boolean. There is no need to backport to stable, IMHO Balbir
