在 2025-11-12星期三的 18:36 +0000,Conor Dooley写道: > On Wed, Nov 12, 2025 at 02:34:39PM +0800, Icenowy Zheng wrote: > > 在 2025-11-11星期二的 18:36 +0000,Conor Dooley写道: > > > On Tue, Nov 11, 2025 at 06:18:16PM +0000, Conor Dooley wrote: > > > > On Sat, Nov 08, 2025 at 02:04:35AM +0100, Michal Wilczynski > > > > wrote: > > > > > Add the dt-binding documentation for the StarFive JH7110 > > > > > Video > > > > > > +patternProperties: > > > > > + "^display@[0-9a-f]+$": > > > > > > > > Personally I'd like to see these being regular properties, > > > > since > > > > there's > > > > exactly one possible setup for this. > > > > > > > > > + type: object > > > > > + description: Verisilicon DC8200 Display Controller node. > > > > > > > > Can you add the relevant references here instead of allowing > > > > any > > > > object? > > > > > > I don't think that if you did, this would pass the binding > > > checks, > > > because there's no "verisilicon,dc" binding. I think I saw one in > > > progress, but without the soc-specific compatible that I am going > > > to > > > require here - if for no reason other than making sure that the > > > clocks > > > etc are provided correctly for this device. > > > > Well I didn't specify any soc-specific compatible because that IP > > has > > its own identification registers. > > I still require one because I want to make sure that clocks etc are > handled correctly. You can ignore it in the driver if you wish, but > when > the next user comes along with one more or less clock, I want the > jh7110 one to be forced to use the correct configuration.
I don't think for those generic IPs requiring a SoC-specific compatible is a good idea. In addition, `vivante,gc` requires no SoC-specific or even model- number-specific compatible strings too, and `verisilicon,dc` is from the same IP vendor [1] and features the same set of identification registers (see also all GC_ prefixed identification registers in [2]). [1] https://www.design-reuse.com/news/202527446-verisilicon-completes-acquisition-of-vivante/ [2] https://github.com/milkv-megrez/rockos-u-boot/blob/c9221cf2fa77d39c0b241ab4b030c708e7ebe279/drivers/video/eswin/eswin_dc_reg.h
