On Mon, Nov 10, 2025 at 07:40:31PM +0100, Andy Shevchenko wrote: > Use %ptSp instead of open coded variants to print content of > struct timespec64 in human readable format. > > Signed-off-by: Andy Shevchenko <[email protected]>
Quite a bit neater, yes. Acked-by: Corey Minyard <[email protected]> > --- > drivers/char/ipmi/ipmi_si_intf.c | 3 +-- > drivers/char/ipmi/ipmi_ssif.c | 6 ++---- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c > b/drivers/char/ipmi/ipmi_si_intf.c > index 70e55f5ff85e..5459ffdde8dc 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -275,8 +275,7 @@ void debug_timestamp(struct smi_info *smi_info, char *msg) > struct timespec64 t; > > ktime_get_ts64(&t); > - dev_dbg(smi_info->io.dev, "**%s: %lld.%9.9ld\n", > - msg, t.tv_sec, t.tv_nsec); > + dev_dbg(smi_info->io.dev, "**%s: %ptSp\n", msg, &t); > } > #else > #define debug_timestamp(smi_info, x) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 1b63f7d2fcda..ef1582a029f4 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1083,10 +1083,8 @@ static int sender(void *send_info, struct ipmi_smi_msg > *msg) > struct timespec64 t; > > ktime_get_real_ts64(&t); > - dev_dbg(&ssif_info->client->dev, > - "**Enqueue %02x %02x: %lld.%6.6ld\n", > - msg->data[0], msg->data[1], > - (long long)t.tv_sec, (long)t.tv_nsec / NSEC_PER_USEC); > + dev_dbg(&ssif_info->client->dev, "**Enqueue %02x %02x: %ptSp\n", > + msg->data[0], msg->data[1], &t); > } > return IPMI_CC_NO_ERROR; > } > -- > 2.50.1 >
