On 06/11/2025 11:46, Krzysztof Kozlowski wrote:
On 06/11/2025 11:36, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>

Properties are now sorted, reset-gpio and port property dropped.

You need to explain why. Sorting is kind of obvious, but dropping
property is not.

"... because they are already accepted here as part of panel-common and
usage of unevaluatedProperties.".

Or just "because they are redundant." if you think reason for redundancy
is obvious.

Yeah, I fight with this a bit, when I get suggestion from reviewer implying something needs to be changed, my brain auto-magically assumes everyone understand why.

I'll try to switch to the mind of "regular commit reader" and think about it for next messages.

Version 2 sent, thanks!>

Fixes: 986f28f3a71e ("dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with 
panel")

No issue/bug to fix here, it's just style. Please drop.

Best regards,
Krzysztof
--
David Heidelberg

Reply via email to