I have noticed that build fails when doing the following: - Start with the x86 defconfig, - Using nconfig, enable `RUST` and `DRM_NOVA`, - Start building.
The problem is that `RUST_FW_LOADER_ABSTRACTIONS` remains unselected, despite it being a dependency of `NOVA_CORE`. This seems to happen because `DRM_NOVA` selects `NOVA_CORE`. Fix this by making `RUST_FW_LOADER_ABSTRACTIONS` select `FW_LOADER`, and by transition make all users of `RUST_FW_LOADER_ABSTRACTIONS` (so far, nova-core and net/phy) select it as well. `FW_LOADER` is more often selected than depended on, so this seems to make sense generally speaking. Signed-off-by: Alexandre Courbot <[email protected]> --- Changes in v3: - Remove `=y` in select statement of RUST_FW_LOADER_ABSTRACTIONS. - Link to v2: https://lore.kernel.org/r/[email protected] Changes in v2: - Split into 3 patches. - Link to v1: https://lore.kernel.org/r/[email protected] --- Alexandre Courbot (3): firmware_loader: make RUST_FW_LOADER_ABSTRACTIONS select FW_LOADER gpu: nova-core: select RUST_FW_LOADER_ABSTRACTIONS net: phy: select RUST_FW_LOADER_ABSTRACTIONS drivers/base/firmware_loader/Kconfig | 2 +- drivers/gpu/nova-core/Kconfig | 2 +- drivers/net/phy/Kconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) --- base-commit: ade19c5060dfa39b84a9475a4a6b05e2a8a2b3ac change-id: 20251104-b4-select-rust-fw-aeb1e46bcee9 Best regards, -- Alexandre Courbot <[email protected]>
