On Tue, Nov 4, 2025 at 3:30 PM Krzysztof Kozlowski <[email protected]> wrote: > > On Mon, Nov 03, 2025 at 07:06:47PM +0800, Junjie Cao wrote: > > From: Pengyu Luo <[email protected]> > > > > Add Awinic AW99706 backlight binding documentation. > > > > Signed-off-by: Junjie Cao <[email protected]> > > Messed DCO chain. This wasn't here, so you must have altered v1 to add > some weird change. > > This is a blocker, please read carefully submitting patches and DCO. >
Apologies for the DCO mess. The tablet device is currently with Pengyu. He helped with testing and tweaked the .c driver file (patch 2/2) after my change. The entire series was then re-formatted on his machine, which caused his git configuration to be incorrectly applied to the From: line of this dt-binding patch (patch 1/2). I am the actual author of this dt-binding file. I will correct the authorship and DCO chain in v2. > > --- > > Changes in v2: > > - use proper units for properties (Krzysztof) > > - drop non-fixed properties (Krzysztof) > > - add properties(max-brightness, default-brightness) (Krzysztof) > > - Link to v1: > > https://lore.kernel.org/linux-leds/[email protected] > > ... > > > + awinic,dim-mode: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > > + Select dimming mode of the device. > > + 0 = Bypass mode. > > + 1 = DC mode. > > + 2 = MIX mode(PWM at low brightness and DC at high brightness). > > + 3 = MIX-26k mode(MIX mode with different PWM frequency). > > + enum: [ 0, 1, 2, 3 ] > > + default: 1 > > + > > + awinic,sw-freq-hz: > > + description: Boost switching frequency in Hz. > > + enum: [ 300000, 400000, 500000, 600000, 660000, 750000, 850000, > > 1000000, 1200000, 1330000, 1500000, 1700000 ] > > Please wrap code according to the preferred limit expressed in Kernel > coding style (checkpatch is not a coding style description, but only a > tool). > ACK. > > + default: 750000 > > + > > + awinic,sw-ilmt-microamp: > > + description: Switching current limitation in uA. > > + enum: [ 1500000, 2000000, 2500000, 3000000 ] > > + default: 3000000 > > + > > + awinic,iled-max-microamp: > > + description: Maximum LED current setting in uA. > > + minimum: 5000 > > + maximum: 50000 > > + multipleOf: 500 > > + default: 20000 > > + > > + awinic,uvlo-thres-microvolt: > > + description: UVLO(Under Voltage Lock Out) in uV. > > + enum: [ 2200000, 5000000 ] > > + default: 2200000 > > + > > + awinic,ramp-ctl: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > > + Select ramp control and filter of the device. > > + 0 = Fade in/fade out. > > + 1 = Light filter. > > + 2 = Medium filter. > > + 3 = Heavy filter. > > + enum: [ 0, 1, 2, 3 ] > > + default: 2 > > + > > +required: > > + - compatible > > + - reg > > + - enable-gpios > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + aw99706@76 { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > If you cannot find a name matching your device, please check in kernel > sources for similar cases or you can grow the spec (via pull request to > DT spec repo). > I see. backlight@76, thanks for your detailed explanation. Regards, Junjie
