Hi Marco,
Thanks for addressing my previous comments so quickly!
I have one more remark to the wording.
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
>
> This lack of consistency cannot be addressed without refactoring the API.
>
> system_unbound_wq should be the default workqueue so as not to enforce
> locality constraints for random work whenever it's not required.
>
> The above change to the Workqueue API has been introduced by:
>
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
I appreciate you adding the references to existing change, but
I'd rewrite above two lines to:
"This patch continues the effort to refactor worqueue APIs,
which has begun with the change introducing new workqueues:
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag").".
Otherwise, the sentence "The above change to the Workqueue API
has been introduced by" to me suggests that you are trying to
re-introduce or fix something that already exists in the kernel.
--
Best Regards,
Krzysztof
