On 11/4/25 3:26 AM, Liu Ying wrote:
Hello Liu,
+++ b/drivers/gpu/drm/bridge/fsl-ldb.c
@@ -61,24 +61,16 @@ enum fsl_ldb_devtype {
};
struct fsl_ldb_devdata {
- u32 ldb_ctrl;
- u32 lvds_ctrl;
bool lvds_en_bit;
bool single_ctrl_reg;
single_ctrl_reg can be dropped then, as it can be expressed by failing to
get the second register.
Furthermore, with this done, lvds_en_bit is the only member left and hence
struct fsl_ldb_devdata can also be dropped, as IIRC there is no need to
use a structure for device data with only a flag.
I plan to add more bits into the driver match data when adding the MX95,
so I would like to retain these instead of removing them and the adding
them back.
i.MX95 LDB supports two LVDS channels. Two DRM bridges are needed in single
or separate LDB mode, while one DRM bridge is needed in split LDB mode.
What do you refer to by "split LDB mode" , some interleaving or some
such thing ?
Also, each channel connects to a standalone LVDS PHY. All these could make
it intrusive to support i.MX95 LDB in fsl-ldb.c. Maybe, we could discuss
about this later, but IMO this patch should remove struct fsl_ldb_devdata.
It doesn't hurt if we really need to add it back.
OK. The current integration seems to be working fine. Which exact case
are you concerned about, do you have an example ?
