On Mon, Oct 13, 2025 at 3:24 AM Jernej Skrabec <[email protected]> wrote:
>
> Later special plane only driver for DE33 will provide separate
> configuration. This change will also help layer driver migrate away from
> mixer structure.
>
> Signed-off-by: Jernej Skrabec <[email protected]>
> ---
[...]
> diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h
> b/drivers/gpu/drm/sun4i/sun8i_mixer.h
> index 40b800022237..8629e21f9cf6 100644
> --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h
> +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h
> @@ -164,34 +164,44 @@ enum sun8i_mixer_type {
> };
>
> /**
> - * struct sun8i_mixer_cfg - mixer HW configuration
> - * @vi_num: number of VI channels
> - * @ui_num: number of UI channels
> + * struct sun8i_layer_cfg - layer configuration
> * @scaler_mask: bitmask which tells which channel supports scaling
> * First, scaler supports for VI channels is defined and after that,
> scaler
> * support for UI channels. For example, if mixer has 2 VI channels
> without
> * scaler and 2 UI channels with scaler, bitmask would be 0xC.
> * @ccsc: select set of CCSC base addresses from the enumeration above.
> - * @mod_rate: module clock rate that needs to be set in order to have
> - * a functional block.
> * @de_type: sun8i_mixer_type enum representing the display engine
> generation.
> * @scaline_yuv: size of a scanline for VI scaler for YUV formats.
> * @de2_fcc_alpha: use FCC for missing DE2 VI alpha capability
> * Most DE2 cores has FCC. If number of VI planes is one, enable this.
> * @vi_scaler_num: Number of VI scalers. Used on DE2 and DE3.
> - * @map: channel map for DE variants processing YUV separately (DE33)
> */
> -struct sun8i_mixer_cfg {
> - int vi_num;
> - int ui_num;
> +struct sun8i_layer_cfg {
> int scaler_mask;
> int ccsc;
> - unsigned long mod_rate;
> unsigned int de_type;
> unsigned int scanline_yuv;
> unsigned int de2_fcc_alpha : 1;
> unsigned int vi_scaler_num;
> - unsigned int map[6];
> +};
> +
> +/**
> + * struct sun8i_mixer_cfg - mixer HW configuration
> + * @lay_cfg: layer configuration
> + * @vi_num: number of VI channels
> + * @ui_num: number of UI channels
Missing kerneldoc for .de_type field.
Once fixed,
Reviewed-by: Chen-Yu Tsai <[email protected]>
