On 11/3/25 11:36 AM, Matt Coster wrote: Hello Matt,
On 02/11/2025 18:41, Marek Vasut wrote:Since commit e38e8391f30b ("drm/imagination: Use pwrseq for TH1520 GPU power management"), the driver calls power sequencing functions. Add missing dependency on POWER_SEQUENCING, otherwise the kernel may fail to build if the driver is built-in and POWER_SEQUENCING is a module with these linker errors: aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected! aarch64-linux-gnu-ld: drivers/gpu/drm/imagination/pvr_power.o: in function `pvr_power_off_sequence_pwrseq': pvr_power.c:(.text+0x70): undefined reference to `pwrseq_power_off' aarch64-linux-gnu-ld: drivers/gpu/drm/imagination/pvr_power.o: in function `pvr_power_on_sequence_pwrseq': pvr_power.c:(.text+0x88): undefined reference to `pwrseq_power_on' aarch64-linux-gnu-ld: drivers/gpu/drm/imagination/pvr_power.o: in function `pvr_power_init_pwrseq': pvr_power.c:(.text+0xb4): undefined reference to `devm_pwrseq_get'Thanks for the fix! I did send a similar patch[1] last month in response to a test bot report[2], but it slipped my mind to chase an Rb for it so it's never been applied. Do you mind if I take the earlier patch instead of this one, since it doesn't add a hard dependency on POWER_SEQUENCING?
Either fix is fine by me, thank you.
