On Thu, Oct 30, 2025 at 04:27:39PM +0100, Philipp Zabel wrote:
> On Di, 2025-09-23 at 17:13 +0200, Johan Hovold wrote:
> > static int imx_tve_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -546,6 +553,11 @@ static int imx_tve_probe(struct platform_device *pdev)
> > if (ddc_node) {
> > tve->ddc = of_find_i2c_adapter_by_node(ddc_node);
> > of_node_put(ddc_node);
> > +
> > + ret = devm_add_action_or_reset(dev, imx_tve_put_device,
> > + &tve->ddc->dev);
>
> I think this needs to be wrapped in "if (tve->ddc) { }",
> of_find_i2c_adapter_by_node() can return NULL.
Indeed, thanks for catching that. Just sent a v2.
Johan
