Re: [PATCH v2 7/7] drm/client: Flush client buffers with drm_client_buffer_sync()

[Jocelyn Falempe]

On 27/10/2025 13:09, Thomas Zimmermann wrote:

Rename drm_client_framebuffer_flush() to drm_cient_buffer_flush() and
adapt its callers. The old name was left over from previous naming
conventions.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
  drivers/gpu/drm/clients/drm_log.c | 4 ++--
  drivers/gpu/drm/drm_client.c      | 8 ++++----
  include/drm/drm_client.h          | 2 +-
  3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/clients/drm_log.c 
b/drivers/gpu/drm/clients/drm_log.c
index 48636bb1a21e..19e55aa0ed74 100644
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -100,7 +100,7 @@ static void drm_log_clear_line(struct drm_log_scanout 
*scanout, u32 line)
                return;
        iosys_map_memset(&map, r.y1 * fb->pitches[0], 0, height * 
fb->pitches[0]);
        drm_client_buffer_vunmap_local(scanout->buffer);
-       drm_client_framebuffer_flush(scanout->buffer, &r);
+       drm_client_buffer_flush(scanout->buffer, &r);
  }

static void drm_log_draw_line(struct drm_log_scanout *scanout, const char *s,

@@ -133,7 +133,7 @@ static void drm_log_draw_line(struct drm_log_scanout 
*scanout, const char *s,
        if (scanout->line >= scanout->rows)
                scanout->line = 0;
        drm_client_buffer_vunmap_local(scanout->buffer);
-       drm_client_framebuffer_flush(scanout->buffer, &r);
+       drm_client_buffer_flush(scanout->buffer, &r);
  }

static void drm_log_draw_new_line(struct drm_log_scanout *scanout,

diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index e7dfbdeca45a..504ec5bdfa2c 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -430,8 +430,8 @@ drm_client_buffer_create_dumb(struct drm_client_dev 
*client, u32 width, u32 heig
  EXPORT_SYMBOL(drm_client_buffer_create_dumb);

/**

- * drm_client_framebuffer_flush - Manually flush client framebuffer
- * @buffer: DRM client buffer (can be NULL)
+ * drm_client_buffer_flush - Manually flush client buffer
+ * @buffer: DRM client buffer
   * @rect: Damage rectangle (if NULL flushes all)
   *
   * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer 
changes
@@ -440,7 +440,7 @@ EXPORT_SYMBOL(drm_client_buffer_create_dumb);
   * Returns:
   * Zero on success or negative error code on failure.
   */
-int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct 
drm_rect *rect)
+int drm_client_buffer_flush(struct drm_client_buffer *buffer, struct drm_rect 
*rect)
  {
        if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty)
                return 0;
@@ -460,4 +460,4 @@ int drm_client_framebuffer_flush(struct drm_client_buffer 
*buffer, struct drm_re
        return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file,
                                        0, 0, NULL, 0);
  }
-EXPORT_SYMBOL(drm_client_framebuffer_flush);
+EXPORT_SYMBOL(drm_client_buffer_flush);
diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index 690ef04fccce..5ecde0f6f591 100644
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -196,7 +196,7 @@ struct drm_client_buffer {
  struct drm_client_buffer *
  drm_client_buffer_create_dumb(struct drm_client_dev *client, u32 width, u32 
height, u32 format);
  void drm_client_buffer_delete(struct drm_client_buffer *buffer);
-int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct 
drm_rect *rect);
+int drm_client_buffer_flush(struct drm_client_buffer *buffer, struct drm_rect 
*rect);
  int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
                                 struct iosys_map *map_copy);
  void drm_client_buffer_vunmap_local(struct drm_client_buffer *buffer);