On Fri, Oct 24, 2025 at 03:59:50PM +0800, Chaoyi Chen wrote: > Hi Heikki, > > On 10/24/2025 3:43 PM, Heikki Krogerus wrote: > > > I noticed the following statement in typec_register_altmode(): > > > > > > ``` > > > > > > /* The partners are bind to drivers */ > > > if (is_typec_partner(parent)) > > > alt->adev.dev.bus = &typec_bus; > > > > > > ``` > > > > > > If the condition is not met, the bus will not be set, which means > > > bus_notify() > > > won't be able to take effect. Did I miss something? > > Right, that would be the condition that I was talking about. Only > > partner altmodes are used in the bus. > > > > Hold on! Do you need the port altmode instead of the partner altmode? > > If that's the case, then we can't use the bus notifier. So we'll need > > the separate notifier chain after all. > > Yes, we need port altmode. The partner altmode device appears too late for > DRM device, as it only shows up after the corresponding DP device is inserted.
Got it. So just move the declaration of the typec_notify_event() to drivers/usb/typec/bus.h and this patch is OK by me. Sorry again about the misunderstanding. thanks, -- heikki
