Hi!
> On Tue Sep 23, 2025 at 9:22 AM CEST, Pavel Machek wrote:
> > Hi!
> >> > Hi!
> >> >
> >> > > + led-controller@45 {
> >> > > + compatible = "awinic,aw2013";
> >> > > + reg = <0x45>;
> >> > > + #address-cells = <1>;
> >> > > + #size-cells = <0>;
> >> > > +
> >> > > + vcc-supply = <&pm8937_l10>;
> >> > > + vio-supply = <&pm8937_l5>;
> >> > > +
> >> > > + led@0 {
> >> > > + reg = <0>;
> >> > > + function = LED_FUNCTION_STATUS;
> >> > > + led-max-microamp = <5000>;
> >> > > + color = <LED_COLOR_ID_RED>;
> >> > > + };
> >> > > +
> >> > > + led@1 {
> >> > > + reg = <1>;
> >> > > + function = LED_FUNCTION_STATUS;
> >> > > + led-max-microamp = <5000>;
> >> > > + color = <LED_COLOR_ID_GREEN>;
> >> > > + };
> >> > > +
> >> > > + led@2 {
> >> > > + reg = <2>;
> >> > > + function = LED_FUNCTION_STATUS;
> >> > > + led-max-microamp = <5000>;
> >> > > + color = <LED_COLOR_ID_BLUE>;
> >> > > + };
> >> > > + };
> >> > > +};
> >> >
> >> > That's single, 3-color LED, right? Please see LED multicolor support.
> >> As far as i know aw2013 driver does not have multicolor support.
> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> >
> > I believe that needs to be fixed before more bugs are added on top to
> > work around that problem...
> >
> > ...and before that bug is cemented in the ABI.
>
> Honestly I don't think it's reasonable to expect people contributing dts
> to then first start patching existing LED drivers and adding support for
> x y or z to it, and block dts addition on that.
Well, the dts is wrong, it describes three leds when you only have
one.
> At least in postmarketOS the user space components we have (e.g.
> feedbackd) detect the LED things (and most others) automatically since
> various devices have various different setups. So once/if aw2013 gets
> multicolor support, the dts can be updated without problems.
> Sure, maybe today changing something on the N900 which would change
> sysfs paths is not the best idea because people will probably have 10+
> years of random shell scripts lying around, but nowadays we usually have
> better ways of abstraction that can handle that.
I'm pretty sure someone, somewhere will have shell scripts.
BR,
Pavel
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
signature.asc
Description: PGP signature
