On Wed, 22 Oct 2025 10:58:40 +0200 Kory Maincent <[email protected]> wrote:
> On Wed, 22 Oct 2025 10:05:47 +0300 > Tomi Valkeinen <[email protected]> wrote: > > > Hi, > > > > On 14/10/2025 17:32, Kory Maincent wrote: > > > From: "Kory Maincent (TI.com)" <[email protected]> > > > > > > The drm_kms_helper_poll_fini() and drm_atomic_helper_shutdown() helpers > > > should only be called when the device has been successfully registered. > > > Currently, these functions are called unconditionally in tilcdc_fini(), > > > which causes warnings during probe deferral scenarios. > > > > > > [ 7.972317] WARNING: CPU: 0 PID: 23 at > > > drivers/gpu/drm/drm_atomic_state_helper.c:175 > > > drm_atomic_helper_crtc_duplicate_state+0x60/0x68 ... [ 8.005820] > > > drm_atomic_helper_crtc_duplicate_state from > > > drm_atomic_get_crtc_state+0x68/0x108 [ 8.005858] > > > drm_atomic_get_crtc_state from drm_atomic_helper_disable_all+0x90/0x1c8 [ > > > 8.005885] drm_atomic_helper_disable_all from > > > drm_atomic_helper_shutdown+0x90/0x144 [ 8.005911] > > > drm_atomic_helper_shutdown from tilcdc_fini+0x68/0xf8 [tilcdc] [ > > > 8.005957] tilcdc_fini [tilcdc] from tilcdc_pdev_probe+0xb0/0x6d4 [tilcdc] > > > > > > Fix this by moving both drm_kms_helper_poll_fini() and > > > drm_atomic_helper_shutdown() inside the priv->is_registered conditional > > > block, ensuring they only execute after successful device registration. > > > > > > Fixes: 3c4babae3c4a ("drm: Call drm_atomic_helper_shutdown() at > > > shutdown/remove time for misc drivers") Signed-off-by: Kory Maincent > > > (TI.com) <[email protected]> > > > > Should this be cc: stable? > > Indeed I think so. Should I send a new version with the stable tag included? Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
