client: Create client buffers with drm_client_buffer_create_dumb()

Jocelyn Falempe Tue, 21 Oct 2025 06:02:59 -0700

On 20/10/2025 17:04, Thomas Zimmermann wrote:

Rename drm_client_framebuffer_create() to drm_client_buffer_create_dump()
and adapt callers. The new name reflects the function's purpose. Using
dumb buffers is the easiest way for creating a GEM buffer in a drivers-
independent way.


There's also drm_client_buffer_create(), which creates the client buffer
from a preexisting buffer object. This helper can be exported for drivers
that create their own GEM buffer object.


Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <[email protected]>


Signed-off-by: Thomas Zimmermann <[email protected]>
---
  drivers/gpu/drm/clients/drm_log.c | 2 +-
  drivers/gpu/drm/drm_client.c      | 6 +++---
  drivers/gpu/drm/drm_fbdev_dma.c   | 2 +-
  drivers/gpu/drm/drm_fbdev_shmem.c | 2 +-
  drivers/gpu/drm/drm_fbdev_ttm.c   | 2 +-
  include/drm/drm_client.h          | 2 +-
  6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/clients/drm_log.c 
b/drivers/gpu/drm/clients/drm_log.c
index 2d748ab318fe..b8fb9ee9fcf0 100644
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -204,7 +204,7 @@ static int drm_log_setup_modeset(struct drm_client_dev 
*client,
        if (format == DRM_FORMAT_INVALID)
                return -EINVAL;

- scanout->buffer = drm_client_framebuffer_create(client, width, height, format);

+       scanout->buffer = drm_client_buffer_create_dumb(client, width, height, 
format);
        if (IS_ERR(scanout->buffer)) {
                drm_warn(client->dev, "drm_log can't create framebuffer %d %d 
%p4cc\n",
                         width, height, &format);
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index d4c424ff44a9..9105a0b5f468 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -372,7 +372,7 @@ void drm_client_buffer_vunmap(struct drm_client_buffer 
*buffer)
  EXPORT_SYMBOL(drm_client_buffer_vunmap);

/**

- * drm_client_framebuffer_create - Create a client framebuffer
+ * drm_client_buffer_create_dumb - Create a client buffer backed by a dumb 
buffer
   * @client: DRM client
   * @width: Framebuffer width
   * @height: Framebuffer height
@@ -386,7 +386,7 @@ EXPORT_SYMBOL(drm_client_buffer_vunmap);
   * Pointer to a client buffer or an error pointer on failure.
   */
  struct drm_client_buffer *
-drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 
height, u32 format)
+drm_client_buffer_create_dumb(struct drm_client_dev *client, u32 width, u32 
height, u32 format)
  {
        const struct drm_format_info *info = drm_format_info(format);
        struct drm_device *dev = client->dev;
@@ -422,7 +422,7 @@ drm_client_framebuffer_create(struct drm_client_dev 
*client, u32 width, u32 heig
        drm_mode_destroy_dumb(client->dev, dumb_args.handle, client->file);
        return ERR_PTR(ret);
  }
-EXPORT_SYMBOL(drm_client_framebuffer_create);
+EXPORT_SYMBOL(drm_client_buffer_create_dumb);

/**

   * drm_client_framebuffer_flush - Manually flush client framebuffer
diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
index 17fef288e86b..7d4e557d6a5d 100644
--- a/drivers/gpu/drm/drm_fbdev_dma.c
+++ b/drivers/gpu/drm/drm_fbdev_dma.c
@@ -285,7 +285,7 @@ int drm_fbdev_dma_driver_fbdev_probe(struct drm_fb_helper 
*fb_helper,

format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,

                                             sizes->surface_depth);
-       buffer = drm_client_framebuffer_create(client, sizes->surface_width,
+       buffer = drm_client_buffer_create_dumb(client, sizes->surface_width,
                                               sizes->surface_height, format);
        if (IS_ERR(buffer))
                return PTR_ERR(buffer);
diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c 
b/drivers/gpu/drm/drm_fbdev_shmem.c
index f7966b8c51cd..b9e48a0bd39f 100644
--- a/drivers/gpu/drm/drm_fbdev_shmem.c
+++ b/drivers/gpu/drm/drm_fbdev_shmem.c
@@ -149,7 +149,7 @@ int drm_fbdev_shmem_driver_fbdev_probe(struct drm_fb_helper 
*fb_helper,
                    sizes->surface_bpp);

format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp, sizes->surface_depth);

-       buffer = drm_client_framebuffer_create(client, sizes->surface_width,
+       buffer = drm_client_buffer_create_dumb(client, sizes->surface_width,
                                               sizes->surface_height, format);
        if (IS_ERR(buffer))
                return PTR_ERR(buffer);
diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
index 54f9a46b96c2..b1188692399a 100644
--- a/drivers/gpu/drm/drm_fbdev_ttm.c
+++ b/drivers/gpu/drm/drm_fbdev_ttm.c
@@ -189,7 +189,7 @@ int drm_fbdev_ttm_driver_fbdev_probe(struct drm_fb_helper 
*fb_helper,

format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,

                                             sizes->surface_depth);
-       buffer = drm_client_framebuffer_create(client, sizes->surface_width,
+       buffer = drm_client_buffer_create_dumb(client, sizes->surface_width,
                                               sizes->surface_height, format);
        if (IS_ERR(buffer))
                return PTR_ERR(buffer);
diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index 6019f2712448..e4df404a9645 100644
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -184,7 +184,7 @@ struct drm_client_buffer {
  };

struct drm_client_buffer *

-drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 
height, u32 format);
+drm_client_buffer_create_dumb(struct drm_client_dev *client, u32 width, u32 
height, u32 format);
  void drm_client_buffer_delete(struct drm_client_buffer *buffer);
  int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct 
drm_rect *rect);
  int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,

Re: [PATCH 6/7] drm/client: Create client buffers with drm_client_buffer_create_dumb()

Reply via email to