On 20/10/2025 13:07, Dmitry Baryshkov wrote: > On Sun, Oct 19, 2025 at 07:13:32PM +0200, Krzysztof Kozlowski wrote: >> On 15/10/2025 03:53, Xiangxu Yin via B4 Relay wrote: >>> From: Xiangxu Yin <[email protected]> >>> >>> Describe the DisplayPort controller for Qualcomm SM6150 SoC. >>> >>> Signed-off-by: Xiangxu Yin <[email protected]> >>> --- >>> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 11 >>> +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>> b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>> index >>> 9ac24f99d3ada1c197c9654dc9babebccae972ed..935eca23ce6b30b81b3ad778e5fcacc817a230c3 >>> 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>> @@ -51,6 +51,16 @@ patternProperties: >>> compatible: >>> const: qcom,sm6150-dpu >>> >>> + "^displayport-controller@[0-9a-f]+$": >>> + type: object >>> + additionalProperties: true >>> + properties: >>> + compatible: >>> + items: >>> + - const: qcom,sm6150-dp >>> + - const: qcom,sm8150-dp >> >> 6150 is compatible with 8150 or 8350? I have doubts. > > SM6150 has the same DP controller as SM8150. SM8150 is compatible with > SM8350.
So if SM6150 is EXACTLY the same as SM8150, then describe it in commit msg. If NOT EXACTLY the same, then probably this should be just compatible with 8350. Anyway, proper justification is missing. Existing commit msg is pretty useless, repeat the diff. I can read the diff. Commit msg should explain all the background which is not obvious. Best regards, Krzysztof
