On Thu, Oct 16, 2025 at 10:46:56PM +0200, David Heidelberg wrote:
> On 16/10/2025 22:12, Dmitry Baryshkov wrote:
> > On Thu, Oct 16, 2025 at 06:16:59PM +0200, David Heidelberg via B4 Relay
> > wrote:
> > > From: David Heidelberg <[email protected]>
> > >
> > > Add panel driver used in the OnePlus 6T.
> > >
> > > No datasheet, based mostly on EDK2 init sequence and the downstream
> > > driver.
> > >
> > > Note: This driver doesn't use previously mentioned "samsung,s6e3fc2x01"
> > > by OnePlus 6T device-tree.
> > > The reason is because DDIC itself without knowing the panel type used
> > > with it will not give the driver enough information about the panel used,
> > > as the panel cannot be autodetected.
> > > While would be more practical to support the original compatible,
> > > I would like to avoid it, to prevent confusing devs upstreaming DDICs.
> > >
> > > Based on work of:
> > > Casey Connolly <[email protected]>
> > > Joel Selvaraj <[email protected]>
> > > Nia Espera <[email protected]>
> > >
> > > Signed-off-by: David Heidelberg <[email protected]>
> > > ---
> > > MAINTAINERS | 1 +
> > > drivers/gpu/drm/panel/Kconfig | 13 +
> > > drivers/gpu/drm/panel/Makefile | 1 +
> > > drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c | 399
> > > +++++++++++++++++++++++
> > > 4 files changed, 414 insertions(+)
> > >
> > > +static const struct of_device_id s6e3fc2x01_of_match[] = {
> > > + /* samsung,s6e3fc2x01 will default to the AMS641RW mode (legacy) */
> > > + { .compatible = "samsung,s6e3fc2x01", .data = &ams641rw_mode },
> >
> > Is there a need to probide this kind of legacy?
>
> I don't know. I don't see the need to provide it, but I understood you may
> want to have it. If not, please tell me and I'll happily remove it from next
> version.
Since this never worked as expected and there were no DTs in upstream
that used this compat string, I think it can be dropped.
>
> David
>
> >
> > > + { .compatible = "samsung,s6e3fc2x01-ams641rw", .data = &ams641rw_mode },
> > > + { /* sentinel */ }
> > > +};
> > > +MODULE_DEVICE_TABLE(of, s6e3fc2x01_of_match);
> > > +
> >
>
> --
> David Heidelberg
>
--
With best wishes
Dmitry
