Hi, On 2025-09-24 20:17 UTC, Dmitry Baryshkov wrote: >> msm_dp_audio_prepare is not called because hdmi-codec driver only checks >> and runs hw_params. This commit will add hw_params callback function >> same as drm_connector_hdmi_audio_prepare, so that hdmi-codec driver can >> work with userspace alsa. > >I think something is wrong here. The prepare callback also should be >called. Is it that the prepare callback is called too late?
I have added debug log to hdmi_codec_hw_params() and hdmi_codec_prepare(), but only logs from hdmi_codec_hw_params() are printed without this patch. After applying this patch, hdmi_codec_prepare() is called after hdmi_codec_hw_params(): [ 14.218445] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_hw_params() started [ 14.223004] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_prepare() started [ 14.534614] msm_dpu ae01000.display-controller: [drm:adreno_request_fw] loaded qcom/a660_gmu.bin from new location [ 14.535750] [drm] Loaded GMU firmware v3.1.10 [ 15.727443] rfkill: input handler disabled [ 42.647157] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_hw_params() started [ 42.656774] hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_prepare() started Best regards, Jianfeng
