Hi Marek,
On Thu, 16 Oct 2025 at 11:48, Marek Vasut <[email protected]> wrote:
> On 10/16/25 10:22 AM, Geert Uytterhoeven wrote:
> >> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> >> @@ -2575,6 +2575,22 @@ gic: interrupt-controller@f1010000 {
> >> resets = <&cpg 408>;
> >> };
> >>
> >> + gpu: gpu@fd000000 {
> >> + compatible = "renesas,r8a7796-gpu",
> >> + "img,img-gx6250",
> >> + "img,img-rogue";
> >> + reg = <0 0xfd000000 0 0x40000>;
> >> + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_CORE R8A7796_CLK_ZG>,
> >> + <&cpg CPG_CORE R8A7796_CLK_S2D1>,
> >> + <&cpg CPG_MOD 112>;
> >> + clock-names = "core", "mem", "sys";
> >> + power-domains = <&sysc R8A7796_PD_3DG_A>,
> >> + <&sysc R8A7796_PD_3DG_B>;
> >> + power-domain-names = "a", "b";
> >> + resets = <&cpg 112>;
> >
> > status = "disabled"; ?
>
> The GPU is always present in the SoC, similar to IPMMU/GIC/DMA/VSP/...
These are special, as they are linked from other devices.
And everything needs the GIC.
> which are also never disabled, do we want to disable the GPU by default
> and enable per-board ?
Yes please. We do the same with renesas,*-mali GPU nodes.
The board may not even have graphical output.
Or do you envision using the GPU for more general and headless operation?
> I would argue the GPU should be enabled by default, so the GPU driver
> can do a proper power management of the GPU. If firmware is missing, at
> least power it off on failed probe, if nothing else.
The *_PD_3DG_* domains are powered down anyway when unused.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds