On Tue, 30 Sep 2025, Jonathan Cavitt <[email protected]> wrote: > Add a helper function that computes the product of hdisplay and > vdisplay. > > Signed-off-by: Jonathan Cavitt <[email protected]> > Cc: Matthew Auld <[email protected]> > Cc: Himal Prasad Ghimiray <[email protected]> > Cc: Matthew Brost <[email protected]> > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 2 +- > drivers/gpu/drm/drm_mipi_dbi.c | 2 +- > include/drm/drm_modes.h | 5 +++++ > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > b/drivers/gpu/drm/drm_gem_vram_helper.c > index 90760d0ca071..4ac71c34f4c6 100644 > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > @@ -967,7 +967,7 @@ drm_vram_helper_mode_valid_internal(struct drm_device > *dev, > > max_fbpages = (vmm->vram_size / 2) >> PAGE_SHIFT; > > - fbsize = mode->hdisplay * mode->vdisplay * max_bpp; > + fbsize = drm_mode_display_size(mode) * max_bpp; > fbpages = DIV_ROUND_UP(fbsize, PAGE_SIZE); > > if (fbpages > max_fbpages) > diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c > index e33c78fc8fbd..54212bf85160 100644 > --- a/drivers/gpu/drm/drm_mipi_dbi.c > +++ b/drivers/gpu/drm/drm_mipi_dbi.c > @@ -691,7 +691,7 @@ int mipi_dbi_dev_init(struct mipi_dbi_dev *dbidev, > const struct drm_simple_display_pipe_funcs *funcs, > const struct drm_display_mode *mode, unsigned int > rotation) > { > - size_t bufsize = mode->vdisplay * mode->hdisplay * sizeof(u16); > + size_t bufsize = drm_mode_display_size(mode) * sizeof(u16); > > dbidev->drm.mode_config.preferred_depth = 16; > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > index b9bb92e4b029..775c94c55cda 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -572,4 +572,9 @@ struct drm_display_mode * > drm_mode_create_from_cmdline_mode(struct drm_device *dev, > struct drm_cmdline_mode *cmd); > > +static inline u32 drm_mode_display_size(const struct drm_display_mode *mode) > +{ > + return mode->hdisplay * mode->vdisplay; > +}
All functions here need kernel-doc. I wonder if "size" is specific enough. BR, Jani. > + > #endif /* __DRM_MODES_H__ */ -- Jani Nikula, Intel
