On 10/8/2025 5:03 PM, Jeff Hugo wrote: > On 10/8/2025 12:12 AM, Karol Wachowski wrote: >> From: Andrzej Kacprowski <[email protected]> >> >> The driver was returning ABORTED for all errors that trigger engine >> reset. > > This is past tense (was). I believe coding style says that commit text > should be in the present tense (is). "The driver is returning ABORTED..." Fixed that commit message before merging. > >> It is better to distinguish between different error types by returning >> the actual error code reported by firmware. This allows userspace to >> take different actions based on the error type and improves >> debuggability. >> >> Refactor ivpu_job_signal_and_destroy() by extracting engine error >> handling logic into a new function ivpu_job_handle_engine_error(). >> This simplifies engine error handling logic by removing necessity of >> calling ivpu_job_singal_and_destroy() multiple times by a single job >> changing it's behavior based on job status. >> >> Signed-off-by: Andrzej Kacprowski <[email protected]> >> Signed-off-by: Karol Wachowski <[email protected]> > > I don't see a need for a v3 to do a minor tweak to the commit text > when it seems reasonable to just inline that at merge. Thank you. Applied with corrected text to drm-misc-next. > > Reviewed-by: Jeff Hugo <[email protected]>
