On 2025-10-17 at 12:41 +1100, Alexandre Courbot <[email protected]> wrote... > On Fri Oct 17, 2025 at 9:56 AM JST, Alistair Popple wrote: > > On 2025-10-16 at 17:24 +1100, Alexandre Courbot <[email protected]> > > wrote... > >> On Mon Oct 13, 2025 at 3:20 PM JST, Alistair Popple wrote: > >> > Adds bindings and an in-place initialiser for the GspSystemInfo struct. > >> > > >> > Signed-off-by: Alistair Popple <[email protected]> > >> > >> I am getting a new unused warnings on this patch - we should either > >> annotate or merge. > > > > Yeah there are quite a few unused warnings. They're a pain to deal with > > during > > patch revisions and rebasing/rewriting so I was waiting until all the > > comments > > settled down before dealing with them as it's pretty tedious work adding > > lint > > statements in one patch and removing them in the next. > > > > As you say the easiest solution is just to merge patches, but that just > > promotes > > larger patches. I wish we didn't have to make that trade off, but I guess > > if we > > want clippy bisection to be clean we have to. > > > > I will probably just merge all the bindings into the patches that use them. > > Miguel's suggestion of adding a temporary, file-global `expect(unused)` > directive would also work very well if you want to preserve the patch > sequence.
Yeah, I quite liked that suggestion as a way of alleviating some of the tedium. But given the bindings are pretty self-contained anyway lets just squash them.
