On Mon, Oct 06, 2025 at 12:10:05PM +0200, Konrad Dybcio wrote: > On 10/6/25 12:02 PM, Dmitry Baryshkov wrote: > > On Mon, Oct 06, 2025 at 11:24:35AM +0200, Konrad Dybcio wrote: > >> On 10/2/25 4:04 AM, Dmitry Baryshkov wrote: > >>> On Wed, Oct 01, 2025 at 09:59:14PM +0800, Junjie Cao wrote: > >>>> Add a driver for panels using the Novatek NT36532 Display Driver IC, > >>>> including support for the CSOT PPC100HB1-1, found in the OnePlus Pad 2 > >>>> tablets. > >>>> > >>>> Signed-off-by: Junjie Cao <[email protected]> > >>>> --- > >>>> MAINTAINERS | 7 + > >>>> drivers/gpu/drm/panel/Kconfig | 10 + > >>>> drivers/gpu/drm/panel/Makefile | 1 + > >>>> drivers/gpu/drm/panel/panel-novatek-nt36532.c | 437 ++++++++++++++++++ > >>>> 4 files changed, 455 insertions(+) > >>>> create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36532.c > >>>> > >>>> + > >>>> +static const struct panel_info csot_panel_info = { > >>>> + .width_mm = 250, > >>>> + .height_mm = 177, > >>>> + .lanes = 4, > >>>> + .format = MIPI_DSI_FMT_RGB888, > >>>> + .mode_flags = MIPI_DSI_MODE_VIDEO | > >>>> MIPI_DSI_CLOCK_NON_CONTINUOUS | > >>>> + MIPI_DSI_MODE_LPM, > >>>> + .display_mode = csot_display_mode, > >>>> + .dsc_slice_per_pkt = 2, > >>> > >>> As this is not a part of the standard, what if the DSI host doesn't > >>> support this feature? > >> > >> Shouldn't the core gracefully throw something like an -EINVAL? > > > > There is no 'core' here. Each DSI DRM host manages DSC on their own. > > drm_dsc_helper?
No, that's just for calculating PPS and some other values. It's one of the problems of the DSI model, which I tried to solve a year ago, but failed up to now to do it completely and clearly. The DSI device can't check host's capabilities. It declares what it needs inside struct mipi_dsi_device and hopes for the best. -- With best wishes Dmitry
