On 15/10/2025 14:00, Boris Brezillon wrote:
> GPU_COHERENCY_PROTOCOL takes one of GPU_COHERENCY_xx
> not BIT(GPU_COHERENCY_xx).
> 
> v3:
> - New commit
> 
> Cc: Akash Goel <[email protected]>
> Fixes: dd7db8d911a1 ("drm/panthor: Explicitly set the coherency mode")
> Reported-by: Steven Price <[email protected]>
> Signed-off-by: Boris Brezillon <[email protected]>

Reviewed-by: Steven Price <[email protected]>

> ---
>  drivers/gpu/drm/panthor/panthor_gpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c 
> b/drivers/gpu/drm/panthor/panthor_gpu.c
> index 9d98720ce03f..7f9a28e90409 100644
> --- a/drivers/gpu/drm/panthor/panthor_gpu.c
> +++ b/drivers/gpu/drm/panthor/panthor_gpu.c
> @@ -49,7 +49,7 @@ struct panthor_gpu {
>  static void panthor_gpu_coherency_set(struct panthor_device *ptdev)
>  {
>       gpu_write(ptdev, GPU_COHERENCY_PROTOCOL,
> -             ptdev->coherent ? GPU_COHERENCY_PROT_BIT(ACE_LITE) : 
> GPU_COHERENCY_NONE);
> +               ptdev->coherent ? GPU_COHERENCY_ACE_LITE : 
> GPU_COHERENCY_NONE);
>  }
>  
>  static void panthor_gpu_l2_config_set(struct panthor_device *ptdev)

Reply via email to