On 10/15/25 12:00 PM, Liu Ying wrote:
Hi,
I wanted to put this whole thing on the list first, before I start splitting it
up.
For starters, I think I can send these separately:
Before discussing how to split, a bigger question is that is it fine to
support both i.MX8qxp DC and i.MX95 DC in the same imx8_dc_drm module?
Separate modules look more reasonable to me, considering the fact that
there are quite a lot difference between the two DCs.
(maybe I do not quite understand your suggestion with "separate module",
I assume this means entirely duplicate driver, is that correct? I
operate with that assumption in the text below.)
This series indicates that the functional units in the DC are basically
identical, with the majority of changes being register base addresses of
the whole DC and an odd bit or register offset here and there. Most of
the code can be reused, as can be seen in the first half of the series.
The addition of iMX95 into the iMX8QXP DC also does not seem to be
making the driver in any way more complicated.
What would be the benefit of having duplicate driver for IP that is
basically identical, for i.MX95 ?
[...]
- drm/imx: dc: Rename i.MX8QXP specific Link IDs
TBH, I'm not a big fan of adding LINK_ID_x_MXy to enum dc_link_id, since
the members may have the same value and it's kind of a mess considering
future SoCs.
I am open to a better suggestion which does not involve duplicate driver.
- drm/imx: Add more RGB swizzling options
This one seems ok.
I can send that one separately. Can you test that on MX8QXP ? I don't
have a board with that SoC, sorry.
[...]
I kind of opt to separate modules. Maybe, to save some code, an additional
module can be introduced to wrap common part as helpers, plus some callback
magics, like fg->dc_fg_cfg_videomode().
Let me ask for clarification here -- by separate modules, do you mean
two totally separate drivers ?
