On 2025-10-17 at 06:22 +1100, Miguel Ojeda <[email protected]> wrote... > On Thu, Oct 16, 2025 at 8:24 AM Alexandre Courbot <[email protected]> wrote: > > > > There are lots of unused warnings when building on this commit. I know > > we don't like big patches, but since this is semantically related to the > > next one and the two touch different files anyway, how about merging > > them? IMHO this is preferable to adding lots of `#[expect(unused)]` that > > we are going to remove right after. > > > > If you have been told to split in a previous version, let's just add a > > the `#[expect(unused)]` where needed.
No, I just split it here because it seemed like a nice self-contained thing. That and I'm conditioned to linux-mm patches where 20 changes is often considered a big patch :-) So I will probably just squash this as suggested. > > A possible middle-ground is to add the `expect` in a "more global" > position, e.g. at the top, so that it is a single line change. I think > that is fine as long as it is removed right after. That could work, thanks. > Thanks! > > Cheers, > Miguel
