On 06/10/2025 09:28, Boris Brezillon wrote:
On Sat,  4 Oct 2025 11:30:50 +0200
Loïc Molinari <[email protected]> wrote:

diff --git a/drivers/gpu/drm/panthor/panthor_drv.c 
b/drivers/gpu/drm/panthor/panthor_drv.c
index fdbe89ef7f43..a2be3b904ca2 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -1623,6 +1624,12 @@ static const struct drm_driver panthor_drm_driver = {
  #endif
  };
+#ifdef CONFIG_TRANSPARENT_HUGEPAGE
+bool panthor_transparent_hugepage;
+module_param_named(transparent_hugepage, panthor_transparent_hugepage, bool, 
0400);
+MODULE_PARM_DESC(transparent_hugepage, "Use a dedicated tmpfs mount point with 
Transparent Hugepage enabled (false = default)");

nit: I'd go for a slightly shorter name, like [panthor_]enable_thp.

For v4, in order to be consistent with the "transparent_hugepage*" kernel parameters, I'd prefer to keep the "panthor.transparent_hugepage" (and "panfrost.transparent_hugepage") module parameter name

I could keep the parameter name as is and change the variable name though.

The patch is

Reviewed-by: Boris Brezillon <[email protected]>

regardless.

Reply via email to