On Thu Oct 9, 2025 at 6:51 PM CEST, Mohamed Ahmed wrote: >> Let's move the call to select_page_shift() into op_map_prepare(). > > How would this work? Originally when we were working on this, we did > place it in op_map_prepare() but we ran into the issue where > nouveau_uvmm_vmm_put() needed the page_shift retrieved (see > nouveau_uvmm_sm_prepare_unwind()).
- ret = op_map_prepare(uvmm, &new->map, &op->map, args, PAGE_SHIFT); + ret = op_map_prepare(uvmm, &new->map, &op->map, args, + select_page_shift(uvmm, &op->map)); You can move this call to select_page_shift() into op_map_prepare(), that's not related to nouveau_uvmm_sm_prepare_unwind(), right?
