пн, 6 жовт. 2025 р. о 23:31 Rob Herring <[email protected]> пише: > > On Thu, Oct 02, 2025 at 08:14:22AM +0300, Svyatoslav Ryhel wrote: > > чт, 2 жовт. 2025 р. о 04:52 Rob Herring <[email protected]> пише: > > > > > > On Thu, Sep 25, 2025 at 06:16:46PM +0300, Svyatoslav Ryhel wrote: > > > > Document CSI HW block found in Tegra20 and Tegra30 SoC. > > > > > > > > Signed-off-by: Svyatoslav Ryhel <[email protected]> > > > > --- > > > > .../display/tegra/nvidia,tegra20-csi.yaml | 135 ++++++++++++++++++ > > > > 1 file changed, 135 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > > > > > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > > new file mode 100644 > > > > index 000000000000..817b3097846b > > > > --- /dev/null > > > > +++ > > > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > > @@ -0,0 +1,135 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: > > > > http://devicetree.org/schemas/display/tegra/nvidia,tegra20-csi.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: NVIDIA Tegra20 CSI controller > > > > + > > > > +maintainers: > > > > + - Svyatoslav Ryhel <[email protected]> > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - nvidia,tegra20-csi > > > > + - nvidia,tegra30-csi > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: true > > > > + clock-names: true > > > > + > > > > + avdd-dsi-csi-supply: > > > > + description: DSI/CSI power supply. Must supply 1.2 V. > > > > + > > > > + power-domains: > > > > + maxItems: 1 > > > > + > > > > + "#nvidia,mipi-calibrate-cells": > > > > + description: > > > > + The number of cells in a MIPI calibration specifier. Should be 1. > > > > + The single cell specifies an id of the pad that need to be > > > > + calibrated for a given device. Valid pad ids for receiver would > > > > be > > > > + 0 for CSI-A; 1 for CSI-B; 2 for DSI-A and 3 for DSI-B. > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + const: 1 > > > > > > Sorry I didn't bring this up before, but is this ever not 1? If it is > > > fixed, then you don't really need the property. I prefer it just be > > > fixed rather than getting a bunch of vendor specific #foo-cells. > > > > > > > This is not an introduction of property, such property already exists > > in Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > and is used in multiple device trees. As I have told before, in case > > of Tegra30 and Tegra20 CSI block combines mipi calibration function > > and CSI function, in Tegra114+ mipi calibration got a dedicated > > hardware block which is already supported. This property here is used > > to align with mipi-calibration logic used by Tegra114+ > > Okay. > > You will have to continue to tell me again if my past questions are not > addressed in the commit message. A review only last week was 100+ > patches ago. Don't expect I'll remember nor go re-read prior versions. >
That is not a problem, I did not meant to offend you. I will add info into commit message. > Ideally, we don't define the type of a property more than once. So this > should really first be moved to its own shared schema that's referenced > here and in the original user. Then it is perfectly clear reading the > patches that this is not a new property. > I am not sure that creating a dedicated shared schema for a single properly which is used by 2 schemas worth it, though, if it is preferred, may the refactoring be done in followups later? > Rob
