On Mon, Sep 29, 2025 at 12:48 AM Nicolas Frattaroli <[email protected]> wrote: > > As it stands, panthor keeps a cached current frequency value for when it > wants to retrieve it. This doesn't work well for when things might > switch frequency without panthor's knowledge. > > Instead, implement the get_cur_freq operation, and expose it through a > helper function to the rest of panthor. > > Reviewed-by: Steven Price <[email protected]> > Reviewed-by: AngeloGioacchino Del Regno > <[email protected]> > Signed-off-by: Nicolas Frattaroli <[email protected]> > --- > drivers/gpu/drm/panthor/panthor_devfreq.c | 33 > +++++++++++++++++++++++++++---- > drivers/gpu/drm/panthor/panthor_devfreq.h | 2 ++ > drivers/gpu/drm/panthor/panthor_device.h | 3 --- > drivers/gpu/drm/panthor/panthor_drv.c | 4 +++- > 4 files changed, 34 insertions(+), 8 deletions(-) > [...] > + > +unsigned long panthor_devfreq_get_freq(struct panthor_device *ptdev) > +{ > + struct panthor_devfreq *pdevfreq = ptdev->devfreq; > + unsigned long freq = 0; > + int ret; > + > + if (!pdevfreq || !pdevfreq->devfreq) > + return 0; > + > + if (pdevfreq->devfreq->profile->get_cur_freq) { This and the other two NULL checks above seem unnecessary. But let's follow other functions and check for pdevfreq->devfreq only.
With that, Reviewed-by: Chia-I Wu <[email protected]> > + ret = > pdevfreq->devfreq->profile->get_cur_freq(ptdev->base.dev, > + &freq); > + if (ret) > + return 0; > + } > + > + return freq; > +} > diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.h > b/drivers/gpu/drm/panthor/panthor_devfreq.h > index > b7631de695f7d79456478c87e8af5dc47673cd1d..f8e29e02f66cb3281ed4bb4c75cda9bd4df82b92 > 100644 > --- a/drivers/gpu/drm/panthor/panthor_devfreq.h > +++ b/drivers/gpu/drm/panthor/panthor_devfreq.h > @@ -18,4 +18,6 @@ void panthor_devfreq_suspend(struct panthor_device *ptdev); > void panthor_devfreq_record_busy(struct panthor_device *ptdev); > void panthor_devfreq_record_idle(struct panthor_device *ptdev); > > +unsigned long panthor_devfreq_get_freq(struct panthor_device *ptdev); > + > #endif /* __PANTHOR_DEVFREQ_H__ */ > diff --git a/drivers/gpu/drm/panthor/panthor_device.h > b/drivers/gpu/drm/panthor/panthor_device.h > index > 9f0649ecfc4fc697a21a8b2fc4dd89c8ecf298df..f32c1868bf6d782d99df9dbd0babcea049c917e0 > 100644 > --- a/drivers/gpu/drm/panthor/panthor_device.h > +++ b/drivers/gpu/drm/panthor/panthor_device.h > @@ -214,9 +214,6 @@ struct panthor_device { > /** @profile_mask: User-set profiling flags for job accounting. */ > u32 profile_mask; > > - /** @current_frequency: Device clock frequency at present. Set by > DVFS*/ > - unsigned long current_frequency; > - > /** @fast_rate: Maximum device clock frequency. Set by DVFS */ > unsigned long fast_rate; > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c > b/drivers/gpu/drm/panthor/panthor_drv.c > index > ea4a37b566a8b215f2b7a09c333a696f1dcdb58f..4d59d94c353c3ca76f4b98a411c8f8284efafd08 > 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -25,6 +25,7 @@ > #include <drm/gpu_scheduler.h> > #include <drm/panthor_drm.h> > > +#include "panthor_devfreq.h" > #include "panthor_device.h" > #include "panthor_fw.h" > #include "panthor_gem.h" > @@ -1519,7 +1520,8 @@ static void panthor_gpu_show_fdinfo(struct > panthor_device *ptdev, > drm_printf(p, "drm-cycles-panthor:\t%llu\n", > pfile->stats.cycles); > > drm_printf(p, "drm-maxfreq-panthor:\t%lu Hz\n", ptdev->fast_rate); > - drm_printf(p, "drm-curfreq-panthor:\t%lu Hz\n", > ptdev->current_frequency); > + drm_printf(p, "drm-curfreq-panthor:\t%lu Hz\n", > + panthor_devfreq_get_freq(ptdev)); > } > > static void panthor_show_internal_memory_stats(struct drm_printer *p, struct > drm_file *file) > > -- > 2.51.0 >
