Hi Dmitry,
On 10/1/2025 4:10 AM, Dmitry Baryshkov wrote:
On Tue, Sep 30, 2025 at 05:09:06PM +0800, Damon Ding wrote:
As suggested by Dmitry, the DRM legacy bridge driver can be pulled
out of imx/ subdir for multi-platform use. The driver is also renamed
to make it more generic and suitable for platforms other than i.MX.
Additionally, a new API drm_bridge_is_legacy() is added to identify
the legacy bridge, allowing specialized handling for such cases.
Why do you need special handling for it?
As you suggested, I will remove this API and add a temporary flag to the
Exynos side.
Signed-off-by: Damon Ding <[email protected]>
Suggested-by: Dmitry Baryshkov <[email protected]>
---
drivers/gpu/drm/bridge/Kconfig | 10 ++
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/imx/Kconfig | 10 --
drivers/gpu/drm/bridge/imx/Makefile | 1 -
.../gpu/drm/bridge/imx/imx-legacy-bridge.c | 91 -----------------
drivers/gpu/drm/bridge/legacy-bridge.c | 99 +++++++++++++++++++
drivers/gpu/drm/imx/ipuv3/Kconfig | 4 +-
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 6 +-
drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 +-
include/drm/bridge/imx.h | 17 ----
include/drm/bridge/legacy-bridge.h | 18 ++++
11 files changed, 135 insertions(+), 126 deletions(-)
delete mode 100644 drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
create mode 100644 drivers/gpu/drm/bridge/legacy-bridge.c
delete mode 100644 include/drm/bridge/imx.h
create mode 100644 include/drm/bridge/legacy-bridge.h
I'm slightly concerned with the name of 'legacy drm bridge', It was fine
for 'i.MX legacy', but now it might be a bit of overkill. Maybe
something like drm_display_mode or drm_of_display_mode bridge?
The 'drm_of_display_mode_bridge' is more descriptive. Compared to that,
the 'legacy-bridge' is somewhat ambiguous.
Apologies for the delayed reply as I was on vacation. ;-)
Best regards,
Damon
