>-----Original Message----- >From: dri-devel <[email protected]> On Behalf Of >Christian König >Sent: Monday, October 6, 2025 9:47 AM >To: [email protected]; [email protected]; dri- >[email protected]; [email protected]; >[email protected] >Subject: [PATCH 1/2] dma-buf: replace "#if" with just "if" > >No need to conditional compile that code, let the compilers dead code >elimination handle it instead.
Makes sense to me. Reviewed-by: Michael J. Ruhl <[email protected]> >Signed-off-by: Christian König <[email protected]> >--- > drivers/dma-buf/dma-buf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c >index 2bcf9ceca997..2305bb2cc1f1 100644 >--- a/drivers/dma-buf/dma-buf.c >+++ b/drivers/dma-buf/dma-buf.c >@@ -1141,8 +1141,7 @@ struct sg_table *dma_buf_map_attachment(struct >dma_buf_attachment *attach, > } > mangle_sg_table(sg_table); > >-#ifdef CONFIG_DMA_API_DEBUG >- { >+ if (IS_ENABLED(CONFIG_DMA_API_DEBUG)) { > struct scatterlist *sg; > u64 addr; > int len; >@@ -1154,10 +1153,10 @@ struct sg_table >*dma_buf_map_attachment(struct dma_buf_attachment *attach, > if (!PAGE_ALIGNED(addr) || !PAGE_ALIGNED(len)) { > pr_debug("%s: addr %llx or len %x is not page >aligned!\n", > __func__, addr, len); >+ break; > } > } > } >-#endif /* CONFIG_DMA_API_DEBUG */ > return sg_table; > > error_unmap: >-- >2.43.0
