Hi Dmitry, > On Mon, Sep 29, 2025 at 02:31:03PM +0800, Chu Guangqing wrote: > > add support for Yhgc BMC soc chipset > > So... Again, what is Yhgc? Please expand your commit message, MAINTAINERS > and Kconfig entries. (this is a usual thing: if you get a review question, it > usually means that you need to provide more information _in_ the patch > rather than just reporting on the mailing list). I'd suggest adding full > company > name and maybe a website as a comment inside the driver code. Otherwise it > would be very hard to assess in few years whether it's something that is > still in > use, whether it needs improvements, etc. > This is a spelling error, it should be YHGCH. which has been corrected and is now in uppercase. The chip introduction has been added to the commit message, and the company's website has been included in the MAINTAINERS file and the source code.
The v8 patch: https://lore.kernel.org/all/20250929104831.8548-1-chuguangq...@inspur.com/ > > > > Signed-off-by: Chu Guangqing <chuguangq...@inspur.com> > > --- > > MAINTAINERS | 5 + > > drivers/gpu/drm/Kconfig | 2 + > > drivers/gpu/drm/Makefile | 1 + > > drivers/gpu/drm/yhgch/Kconfig | 11 + > > drivers/gpu/drm/yhgch/Makefile | 4 + > > drivers/gpu/drm/yhgch/yhgch_drm_de.c | 398 Best Regards, Chu Guangqing
