Dmitry,

I got your point. That is actually a good idea I think.
I will move params and list node into struct virtio_gpu_object {} and make other
changes for it as well.

> Subject: Re: [PATCH v4 3/3] drm/virtio: Restore Virt-GPU res on hibernation
> resume via PM notifier
> 
> On 9/24/25 22:47, dongwon....@intel.com wrote:
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c
> > b/drivers/gpu/drm/virtio/virtgpu_kms.c
> > index 08f8e71a7072..e1b2cee30fa3 100644
> > --- a/drivers/gpu/drm/virtio/virtgpu_kms.c
> > +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c
> > @@ -26,9 +26,12 @@
> >  #include <linux/virtio.h>
> >  #include <linux/virtio_config.h>
> >  #include <linux/virtio_ring.h>
> > +#include <linux/suspend.h>
> > +#include <linux/pm_runtime.h>
> >
> >  #include <drm/drm_file.h>
> >  #include <drm/drm_managed.h>
> > +#include <drm/drm_atomic_helper.h>
> 
> There is no need to include drm_atomic_helper.h, AFAICT. Please correct this 
> in
> v5 in addition to addressing comments from Nirmoy Das.
> 
> --
> Best regards,
> Dmitry

Reply via email to