Hi Dmitry, I have read Documentation/process/submitting-patches.rst. however, the content is quite extensive. Please point out any omissions if there are any.
Q:Is there a need to probe here just print an error? A: it will be re-probe at detect_ctx Q:No .disable() ? A: yes, we have only implemented the enable function v5: - remove extra level of subdiretories, change to driver/gpu/drm/yhgch - remove else from > + else if (!new_plane_state->visible) - remove extra check in function yhgch_plane_atomic_check - remove the extra parentheses - change the author like other modules - use drm_edit_read function instead drm_get_edit - remove debug info drm_warn call - rename function name smi_connector_helper_detect_from_ddc to yhgch_connector_helper_detect_from_ddc, remove extra return statement. v4: - remove VRAM helpers from Kconfig - use the coding style in ast/mgag200 for the DDC - use plane_state->dst instead of crtc_h/w/x/y. - delete duplicate framebuffer's atomic_check. - use FIELD_PREP() directly. - use dev->mode_config. - delete unnecessary drm_atomic_helper_shutdown call - add AUTHOR - using .enable instead (https://lore.kernel.org/all/20250924064954.3921-1-chuguangq...@inspur.com/) v3: - The order of the code blocks has been adjusted, and the "warn-on" branch has been removed. - removed the related formats for the alpha channel. - removed the atomic_flush function. - have removed the empty line. - have removed the error message here. - replaced it with the drmm_encoder_init function. (https://lore.kernel.org/all/20250910022311.2655-1-chuguangq...@inspur.com/) v2: - Delete unnecessary comments - Delete unnecessary branch - Use drm_atomic_helper_check_plane_state - remove the alpha formats form this list. - use w,h rather than x, y - delete type casting - use a simple call to drm_atomic_helper_shutdown() - delete yhgch_load function - delete vblanking code - delete unneeded i2c type (https://lore.kernel.org/all/20250903054533.68540-1-chuguangq...@inspur.com/) v1: (https://lore.kernel.org/all/20250808053508.52202-1-chuguangq...@inspur.com/) Chu Guangqing (1): [DRIVER] gpu: drm: add support for Yhgc ZX1000 soc chipset MAINTAINERS | 5 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/yhgch/Kconfig | 11 + drivers/gpu/drm/yhgch/Makefile | 4 + drivers/gpu/drm/yhgch/yhgch_drm_de.c | 415 +++++++++++++++++++++++++ drivers/gpu/drm/yhgch/yhgch_drm_drv.c | 310 ++++++++++++++++++ drivers/gpu/drm/yhgch/yhgch_drm_drv.h | 51 +++ drivers/gpu/drm/yhgch/yhgch_drm_i2c.c | 114 +++++++ drivers/gpu/drm/yhgch/yhgch_drm_regs.h | 208 +++++++++++++ drivers/gpu/drm/yhgch/yhgch_drm_vdac.c | 121 +++++++ 11 files changed, 1242 insertions(+) create mode 100644 drivers/gpu/drm/yhgch/Kconfig create mode 100644 drivers/gpu/drm/yhgch/Makefile create mode 100644 drivers/gpu/drm/yhgch/yhgch_drm_de.c create mode 100644 drivers/gpu/drm/yhgch/yhgch_drm_drv.c create mode 100644 drivers/gpu/drm/yhgch/yhgch_drm_drv.h create mode 100644 drivers/gpu/drm/yhgch/yhgch_drm_i2c.c create mode 100644 drivers/gpu/drm/yhgch/yhgch_drm_regs.h create mode 100644 drivers/gpu/drm/yhgch/yhgch_drm_vdac.c -- 2.43.5