On Tue, 09 Sep 2025, S Sebinraj <[email protected]> wrote: > diff --git a/drivers/gpu/drm/xe/xe_gpu_freq_trace.h > b/drivers/gpu/drm/xe/xe_gpu_freq_trace.h > new file mode 100644 > index 000000000000..f188d529ae60 > --- /dev/null > +++ b/drivers/gpu/drm/xe/xe_gpu_freq_trace.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * GPU frequency trace wrapper for xe_pmu.c > + * This header provides access to the gpu_frequency tracepoint */ > +#ifndef _XE_GPU_FREQ_TRACE_H_ #define _XE_GPU_FREQ_TRACE_H_ > + > +#include "../drm_gpu_frequency_trace.h"
> This is a no go. You can't include drm headers with relative paths like this. > Basically none of the drm headers inside drivers/gpu/drm/ are for drivers, > they're internal. Indeed, they usually have _internal.h suffix to emphasize > that. > Headers for drivers need to be placed under include/drm/ > BR, > Jani. Okay got it, I will check and update it in the next revision.
