On 9/10/2025 9:25 AM, Alexandre Courbot wrote:
>>> I agree the `: u32` can be introduced later, the original `register!`
>>> macro did not specify any type information so there is indeed no reason
>>> to add it in this patch.
>>>> Yep.
>> When you introduce the types, can you change the syntax from `: u32` to
> `(u32)`? That way the declaration becomes
>
> bitfield! {
> struct ControlReg(u32) {
> ...
> }
> }
>
> ... which at least looks like a valid declaration for a Rust struct
> that wraps a primitive type. Same for registers, if possible.
Sure, I agree with your suggestion and will make the changes.
thanks,
- Joel
- [PATCH v2 0/4] Improve bitfield support in Rust Joel Fernandes
- [PATCH v2 1/4] nova-core: bitstruct: Move bitfield-... Joel Fernandes
- Re: [PATCH v2 1/4] nova-core: bitstruct: Move b... Alexandre Courbot
- Re: [PATCH v2 1/4] nova-core: bitstruct: Mo... Joel Fernandes
- Re: [PATCH v2 1/4] nova-core: bitstruct... Alexandre Courbot
- Re: [PATCH v2 1/4] nova-core: bits... Joel Fernandes
- Re: [PATCH v2 1/4] nova-core: ... Alexandre Courbot
- Re: [PATCH v2 1/4] nova-co... Joel Fernandes
- [PATCH v2 4/4] rust: Move register and bitstruct ma... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register and bits... Daniel Almeida
- Re: [PATCH v2 4/4] rust: Move register and ... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register and bits... Elle Rhumsaa
- Re: [PATCH v2 4/4] rust: Move register and bits... Miguel Ojeda
- Re: [PATCH v2 4/4] rust: Move register and ... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register ... Miguel Ojeda
- Re: [PATCH v2 4/4] rust: Move regi... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move regi... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register and bits... Alexandre Courbot
