On Thu, Aug 21, 2025 at 01:46:21PM +0200, Thomas Hellström wrote:
> +struct mmu_interval_notifier_finish {
> + struct list_head link;
> + /**
> + * @finish: Driver callback for the finish pass.
> + * @final: Pointer to the mmu_interval_notifier_finish structure.
> + * @range: The mmu_notifier_range.
> + * @cur_seq: The current sequence set by the first pass.
> + *
> + * Note that there is no error reporting for additional passes.
> + */
> + void (*finish)(struct mmu_interval_notifier_finish *final,
> + const struct mmu_notifier_range *range,
> + unsigned long cur_seq);
I would rather this be in mmu_interval_notifier_ops, though I guess I
see why it was done like this, I don't think it is a great idea for
DRM to wrapper the notifier library with yet another library :\
Regardless
Reviewed-by: Jason Gunthorpe <[email protected]>
Jason
