On Wed, 03 Sep 2025, syyang <[email protected]> wrote: > +static int i2c_write_byte(struct lt9611c *lt9611c, u8 reg, u8 val)
> +static int i2c_read_byte(struct lt9611c *lt9611c, u8 reg, u8 *val) > +static int i2c_read_write_flow(struct lt9611c *lt9611c, u8 *params, > + unsigned int param_count, u8 *return_buffer, > + unsigned int return_count) include/linux/i2c.h provides a plethora of i2c_ prefixed functions and types. I think it's bad practice to reuse the prefix of a very common kernel interface, even if in static functions. You might get collisions later, but the reader of the code is mislead to believe this is something in i2c.h. BR, Jani. -- Jani Nikula, Intel
