On Thu, Sep 04, 2025 at 05:10:02PM +0800, Liu Ying wrote: > IT6263 supports HDMI vendor specific infoframe. The infoframe header > and payload are configurable via NULL packet registers. The infoframe > is enabled and disabled via PKT_NULL_CTRL register. Add the HDMI vendor > specific infoframe support. > > Signed-off-by: Liu Ying <[email protected]> > --- > drivers/gpu/drm/bridge/ite-it6263.c | 72 > ++++++++++++++++++++++++++----------- > 1 file changed, 52 insertions(+), 20 deletions(-) > > + case HDMI_INFOFRAME_TYPE_VENDOR: > + const char zero_bulk[HDMI_PKT_HB_PB_CHUNK_SIZE] = { }; > + > + /* clear NULL packet registers due to undefined default value */ > + regmap_bulk_write(regmap, HDMI_REG_PKT_HB(0), > + zero_bulk, sizeof(zero_bulk));
What if you move this to the probe function? Then there will be no need to write those registers each time the infoframe is being written. LGTM otherwise. > + > + /* write header and payload */ > + regmap_bulk_write(regmap, HDMI_REG_PKT_HB(0), buffer, len); > + > + regmap_write(regmap, HDMI_REG_PKT_NULL_CTRL, > + ENABLE_PKT | REPEAT_PKT); > + break; -- With best wishes Dmitry
