Hi, On 11/08/2025 10:59, Harikrishna Shenoy wrote: > From: Jayesh Choudhary <[email protected]> > > Reduce the log level for cdns_mhdp_dpcd_read and cdns_mhdp_dpcd_write > errors in cdns_mhdp_transfer function as in case of failure, there is > flooding of these prints along with other indicators like EDID failure > logs which are fairly intuitive in themselves rendering these error logs > useless. > Also, the caller functions for the cdns_mhdp_transfer in drm_dp_helper.c > (which calls it 32 times), has debug log level in case transfer fails. > So having a superseding log level in cdns_mhdp_transfer seems bad. > > Signed-off-by: Jayesh Choudhary <[email protected]> > --- > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index 47c657237c37..4fb1db3e030c 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -778,7 +778,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux, > if (!ret) > continue; > > - dev_err(mhdp->dev, > + dev_dbg(mhdp->dev, > "Failed to write DPCD addr %u\n", > msg->address + i); > > @@ -788,7 +788,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux, > ret = cdns_mhdp_dpcd_read(mhdp, msg->address, > msg->buffer, msg->size); > if (ret) { > - dev_err(mhdp->dev, > + dev_dbg(mhdp->dev, > "Failed to read DPCD addr %u\n", > msg->address); >
Reviewed-by: Tomi Valkeinen <[email protected]> Tomi
