On Tue, Sep 02, 2025 at 11:35:05AM +0200, Maxime Ripard wrote:
> The vkms_crtc_atomic_check() function calls the deprecated
> drm_atomic_get_existing_plane_state() helper for its internal mode
> checking logic.
>
> During atomic_check, the existing state is the new state and
> drm_atomic_get_existing_plane_state() can thus be replaced by
> drm_atomic_get_new_plane_state().
>
> Signed-off-by: Maxime Ripard <[email protected]>
>
> ---
> To: Louis Chauvet <[email protected]>
> Cc: Haneen Mohammed <[email protected]>
> Cc: Simona Vetter <[email protected]>
> Cc: Melissa Wen <[email protected]>
> Cc: [email protected]
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c
> b/drivers/gpu/drm/vkms/vkms_crtc.c
> index
> e60573e0f3e9510252e1f198b00e28bcc7987620..48237f32ac3b8f78b1495e8fbcc630be863ec7e4
> 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -183,11 +183,11 @@ static int vkms_crtc_atomic_check(struct drm_crtc *crtc,
> ret = drm_atomic_add_affected_planes(crtc_state->state, crtc);
> if (ret < 0)
> return ret;
>
> drm_for_each_plane_mask(plane, crtc->dev, crtc_state->plane_mask) {
> - plane_state =
> drm_atomic_get_existing_plane_state(crtc_state->state, plane);
> + plane_state = drm_atomic_get_new_plane_state(crtc_state->state,
> plane);
Looks like a bunch of these drivers could also use another cleanup
to plumb the drm_atomic_state straight through instead of digging
it up again via the foo_state->state footgun.
> WARN_ON(!plane_state);
>
> if (!plane_state->visible)
> continue;
>
> @@ -199,11 +199,11 @@ static int vkms_crtc_atomic_check(struct drm_crtc *crtc,
> return -ENOMEM;
> vkms_state->num_active_planes = i;
>
> i = 0;
> drm_for_each_plane_mask(plane, crtc->dev, crtc_state->plane_mask) {
> - plane_state =
> drm_atomic_get_existing_plane_state(crtc_state->state, plane);
> + plane_state = drm_atomic_get_new_plane_state(crtc_state->state,
> plane);
>
> if (!plane_state->visible)
> continue;
>
> vkms_state->active_planes[i++] =
>
> --
> 2.50.1
--
Ville Syrjälä
Intel
