On Friday, August 22, 2025 3:14 PM Akhilesh Patil wrote: > Use dev_err_probe() helper as recommended by core driver model in > drivers/base/core.c to handle deferred probe error. Improve code > consistency and debuggability using standard helper. > > Signed-off-by: Akhilesh Patil <[email protected]> > --- > V1 -> V2: addressed review comments as below. > * inline - err = PTR_ERR(host->clk) inside dev_err_probe() > * avoid printing err, as dev_err_probe() prints it internally. > * rebase and compile test with v6.17-rc2 > > drivers/gpu/host1x/dev.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c > index 1f93e5e276c0..c586c242f2c2 100644 > --- a/drivers/gpu/host1x/dev.c > +++ b/drivers/gpu/host1x/dev.c > @@ -585,14 +585,8 @@ static int host1x_probe(struct platform_device *pdev) > } > > host->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(host->clk)) { > - err = PTR_ERR(host->clk); > - > - if (err != -EPROBE_DEFER) > - dev_err(&pdev->dev, "failed to get clock: %d\n", err); > - > - return err; > - } > + if (IS_ERR(host->clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(host->clk), "failed to get > clock\n"); > > err = host1x_get_resets(host); > if (err)
Thanks! Tested-by: Mikko Perttunen <[email protected]> Acked-by: Mikko Perttunen <[email protected]>
