Hi
Am 25.08.25 um 09:26 schrieb Dan Carpenter:
Hi Thomas,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-ast-Do-not-print-DRAM-info/20250822-213333
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
exynos-drm-next
patch link:
https://lore.kernel.org/r/20250822132846.25376-7-tzimmermann%40suse.de
patch subject: [PATCH 6/6] drm/ast: Put AST_DRAM_ constants into enum
ast_dram_layout
config: i386-randconfig-141-20250823
(https://download.01.org/0day-ci/archive/20250824/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:
drivers/gpu/drm/ast/ast_2100.c:63 ast_2100_get_dram_layout_p2a() error:
uninitialized symbol 'dram_layout'.
vim +/dram_layout +63 drivers/gpu/drm/ast/ast_2100.c
334d62edac4c5b Thomas Zimmermann 2025-08-22 38 static enum ast_dram_layout
ast_2100_get_dram_layout_p2a(struct ast_device *ast)
b59465efc7cb88 Thomas Zimmermann 2025-08-22 39 {
b59465efc7cb88 Thomas Zimmermann 2025-08-22 40 u32 mcr_cfg;
334d62edac4c5b Thomas Zimmermann 2025-08-22 41 enum ast_dram_layout
dram_layout;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 42
b59465efc7cb88 Thomas Zimmermann 2025-08-22 43 ast_write32(ast,
0xf004, 0x1e6e0000);
b59465efc7cb88 Thomas Zimmermann 2025-08-22 44 ast_write32(ast,
0xf000, 0x1);
b59465efc7cb88 Thomas Zimmermann 2025-08-22 45 mcr_cfg =
ast_read32(ast, 0x10004);
b59465efc7cb88 Thomas Zimmermann 2025-08-22 46
b59465efc7cb88 Thomas Zimmermann 2025-08-22 47 switch (mcr_cfg & 0x0c)
{
b59465efc7cb88 Thomas Zimmermann 2025-08-22 48 case 0:
b59465efc7cb88 Thomas Zimmermann 2025-08-22 49 case 4:
334d62edac4c5b Thomas Zimmermann 2025-08-22 50 dram_layout =
AST_DRAM_512Mx16;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 51 break;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 52 case 8:
b59465efc7cb88 Thomas Zimmermann 2025-08-22 53 if (mcr_cfg &
0x40)
334d62edac4c5b Thomas Zimmermann 2025-08-22 54
dram_layout = AST_DRAM_1Gx16;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 55 else
334d62edac4c5b Thomas Zimmermann 2025-08-22 56
dram_layout = AST_DRAM_512Mx32;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 57 break;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 58 case 0xc:
334d62edac4c5b Thomas Zimmermann 2025-08-22 59 dram_layout =
AST_DRAM_1Gx32;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 60 break;
Should there be a default case?
Thanks for reporting. That only happens now with the values being an
enum type. The first case (512Mx16) would be the default. Will be fixed
in the next iteration.
Best regards
Thomas
b59465efc7cb88 Thomas Zimmermann 2025-08-22 61 }
b59465efc7cb88 Thomas Zimmermann 2025-08-22 62
334d62edac4c5b Thomas Zimmermann 2025-08-22 @63 return dram_layout;
b59465efc7cb88 Thomas Zimmermann 2025-08-22 64 }
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
